Skip to content

fix(apple_silicon): rename zone imports #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2025
Merged

fix(apple_silicon): rename zone imports #1745

merged 2 commits into from
Jan 27, 2025

Conversation

@scaleway-bot
Copy link
Collaborator

@scaleway-bot scaleway-bot commented Jan 24, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3ee90db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the apple-silicon Apple Silicon issues, bugs and feature requests label Jan 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (c80a70f) to head (3ee90db).
Report is 454 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
- Coverage   94.01%   93.06%   -0.96%     
==========================================
  Files          53       92      +39     
  Lines        3427     5062    +1635     
  Branches      476      960     +484     
==========================================
+ Hits         3222     4711    +1489     
- Misses        205      351     +146

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax changed the title feat(apple_silicon): enable cli for private network chore(apple_silicon): rename zone imports Jan 27, 2025
@Codelax Codelax changed the title chore(apple_silicon): rename zone imports fix(apple_silicon): rename zone imports Jan 27, 2025
@Codelax Codelax added this pull request to the merge queue Jan 27, 2025
Merged via the queue into scaleway:main with commit a531743 Jan 27, 2025
10 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 27, 2025
@scaleway-bot @Codelax
fix(apple_silicon): rename zone imports (#1745)
a531743 
Co-authored-by: Jules Castéran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Codelax Codelax Codelax approved these changes

@Laure-di Laure-di Awaiting requested review from Laure-di

Assignees

No one assigned

Labels

apple-silicon Apple Silicon issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scaleway-bot @codecov-commenter @Codelax